fix: allow warm up with system prompt #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiliaForever
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes warm-up functionality to allow warm-up requests that include a system prompt. The change ensures that models can be properly warmed up even when a system prompt is provided.
- Modified warm-up logic to accept requests with only a system prompt message
- Replaced default struct tags with a constructor function for better default value management
- Updated CLI to include system prompt in warm-up requests when specified
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| runner/server/handler/completion.go | Refactored default values from struct tags to constructor function and updated warm-up condition to allow system prompt |
| runner/cmd/nexa-cli/run.go | Added system prompt to warm-up request and included missing CLI flag for thinking mode |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zhiyuan8
approved these changes
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.